fix: Deprecated strlen(null) in Redis Hashtable on PHP 8.1+#44
Merged
ralflang merged 2 commits intohorde:FRAMEWORK_6_0from Mar 7, 2026
Merged
fix: Deprecated strlen(null) in Redis Hashtable on PHP 8.1+#44ralflang merged 2 commits intohorde:FRAMEWORK_6_0from
ralflang merged 2 commits intohorde:FRAMEWORK_6_0from
Conversation
### Problem On PHP 8.1+, calling `strlen(null)` raises a deprecation warning in Redis Hashtable configuration when no password is set. ### Solution Replaced `strlen()` check with `!empty()` to ensure proper handling of null/empty passwords while preserving previous behavior. ### Compatibility - No change in functionality. - Tested on PHP 8.4
amulet1
reviewed
Feb 18, 2026
lib/Horde/Core/Factory/HashTable.php
Outdated
|
|
||
| $common = array_filter([ | ||
| 'password' => strlen($params['password']) ? $params['password'] : null, | ||
| 'password' => !empty($params['password']) ? $params['password'] : null, |
Contributor
There was a problem hiding this comment.
I would suggest to try null coalescing for cases with possibly missing string parameters:
$value ?? $value_if_missing_or_null
For example:
'password' => $params['password'] ?? null
One caveat is that if $params['password'] is set to empty string, it would not change it to null.
Contributor
There was a problem hiding this comment.
Note, one of the issues with empty() is that it returns true for '0' (or 0).
Since we are modifying this file, it makes sense to improve things.
Address review: use null coalescing operator
Member
|
Thank you, much appreciated! |
Member
|
@amulet1 Please make a follow-up PR with your suggested next improvement as time permits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On PHP 8.1+, calling
strlen(null)raises a deprecation warning in Redis Hashtable configuration when no password is set.Solution
Replaced
strlen()check with!empty()to ensure proper handling of null/empty passwords while preserving previous behavior.Compatibility